Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IOPAE-175] Update RegenerateServiceKey with Manage Flow #265

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

giuseppedipinto
Copy link
Contributor

Added the possibility to use MANAGE Subscription API Key as Ocp-Apim-Subscription-Key in RegenerateServiceKey API.
In this way we are introducing the concept of MANAGE Flow for Service Management APIs.

List of Changes

  • Update RegenerateServiceKey with the possibility to use the MANAGE Subscription API Key
  • Related Unit Tests

Motivation and Context

Reduce User Errors with a restricted API Key scope, especially in case of Service Keys Update.

How Has This Been Tested?

Unit Tests

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@giuseppedipinto giuseppedipinto requested a review from a team as a code owner February 15, 2023 15:30
@github-actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPAE-175

RegenerateServiceKey/__tests__/handler.test.ts Outdated Show resolved Hide resolved
Co-authored-by: Emanuele De Cupis <ema.decu@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@giuseppedipinto giuseppedipinto merged commit ae55f8c into master Feb 15, 2023
@giuseppedipinto giuseppedipinto deleted the IOPAE-175--regenerate-service-key-manage-flow branch February 15, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants