Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPAE-200] update function services with authorized cidrs on manage APIs #268

Merged
merged 1 commit into from
Mar 17, 2023
Merged

[#IOPAE-200] update function services with authorized cidrs on manage APIs #268

merged 1 commit into from
Mar 17, 2023

Conversation

StefanoDoc
Copy link
Contributor

Update function services with authorized cidrs on manage APIs

List of Changes

Add SubscriptionCIDRsModel in AzureUserAttributeManage Middleware for :

  • CreateService
  • RegenerateServiceKey
  • UpdateService
  • UpdateServiceLogo

Motivation and Context

We need to limit the use of Manage Subscription key to an authorized IP List (in CIDRs format).

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@StefanoDoc StefanoDoc requested a review from a team as a code owner March 9, 2023 11:03
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPAE-200

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@StefanoDoc StefanoDoc merged commit f5e68e4 into master Mar 17, 2023
@StefanoDoc StefanoDoc deleted the auth-cidrs-functions-services branch March 17, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balanza balanza balanza approved these changes

@LoFrance LoFrance Awaiting requested review from LoFrance

@giuseppedipinto giuseppedipinto Awaiting requested review from giuseppedipinto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanoDoc @balanza