Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPAE-808]bugfix: remove version from cms api response and documentation #289

Conversation

StefanoDoc
Copy link
Contributor

@StefanoDoc StefanoDoc commented Dec 1, 2023

the version field does not exist in services cms , the service cms api do not return version on response

List of Changes

  • remove version field from services cms api and documentation

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

github-actions bot commented Dec 1, 2023

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPAE-808

@StefanoDoc StefanoDoc marked this pull request as ready for review December 1, 2023 12:55
@StefanoDoc StefanoDoc requested a review from a team as a code owner December 1, 2023 12:55
@gunzip
Copy link
Contributor

gunzip commented Dec 1, 2023

These are breaking changes that needs a major version upgrade of OpenAPI specs.

Who's the consumer of this APIs?

@StefanoDoc
Copy link
Contributor Author

StefanoDoc commented Dec 1, 2023

for the version field this is a optional field on a response , and is an OpenAPI bug that we forgot and left there, the cms api don't return version in response , for the max_allowed_payment_amount i agree , and for now i reverted it , @iwoak do you think we need to deprecate this field first ?

Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@StefanoDoc StefanoDoc changed the title [IOPAE-807]remove versione and max allowed payment from documentation (openapi) [IOPAE-807]bugfix: remove version from cms api response and documentation Dec 1, 2023
@StefanoDoc StefanoDoc changed the title [IOPAE-807]bugfix: remove version from cms api response and documentation [IOPAE-808]bugfix: remove version from cms api response and documentation Dec 1, 2023
@StefanoDoc StefanoDoc merged commit 5f5fcf1 into master Dec 20, 2023
9 checks passed
@StefanoDoc StefanoDoc deleted the IOPAE-807-remove-version-and-max-allowe-payment-from-documentation branch December 20, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants