Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOCOM-888] Remove links from the text in email #295

Merged
merged 1 commit into from
Jan 11, 2024
Merged

[IOCOM-888] Remove links from the text in email #295

merged 1 commit into from
Jan 11, 2024

Conversation

Garma00
Copy link
Contributor

@Garma00 Garma00 commented Jan 11, 2024

List of Changes

Motivation and Context

We want to avoid links when sending an email

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Garma00 Garma00 requested a review from a team as a code owner January 11, 2024 11:12
@Garma00 Garma00 requested review from rodoviti and acuiuli January 11, 2024 11:12
@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-888

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

acuiuli
acuiuli approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@acuiuli acuiuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Garma00 Garma00 merged commit 70e8e01 into master Jan 11, 2024
4 checks passed
@Garma00 Garma00 deleted the IOCOM-888 branch January 11, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acuiuli acuiuli acuiuli approved these changes

@rodoviti rodoviti Awaiting requested review from rodoviti rodoviti is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Garma00 @acuiuli