Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOCOM-1313] feat(openapi): Added remote content manage api #308

Merged
merged 7 commits into from
May 10, 2024
Merged

[IOCOM-1313] feat(openapi): Added remote content manage api #308

merged 7 commits into from
May 10, 2024

Conversation

michaeldisaro
Copy link
Contributor

List of Changes

Added remote content manage APIs and definitions.

Motivation and Context

We need to expose these new APIs on the public guide.

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@michaeldisaro michaeldisaro requested a review from a team as a code owner April 24, 2024 16:31
@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-1313

@iwoak iwoak requested a review from rodoviti April 29, 2024 13:48
iwoak
iwoak reviewed Apr 29, 2024
View reviewed changes
openapi/index.yaml Outdated Show resolved Hide resolved
@michaeldisaro
removed useless base path
7c20961
@michaeldisaro
fix(api): aligned APIs' paths
c6cd990 
fix(tests): fixed mock path for integration tests
angelo-fiorillo
angelo-fiorillo approved these changes May 8, 2024
View reviewed changes
Copy link

@angelo-fiorillo angelo-fiorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK per me

Garma00
Garma00 approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@Garma00 Garma00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little change

openapi/index.yaml.template Outdated Show resolved Hide resolved
openapi/index.yaml.template Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@michaeldisaro
Copy link
Contributor Author

Please do not merge. I'll do it when ready.

@michaeldisaro michaeldisaro merged commit a8207a2 into master May 10, 2024
6 checks passed
@michaeldisaro michaeldisaro deleted the iocom-1313 branch May 10, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwoak iwoak iwoak left review comments

@gunzip gunzip gunzip left review comments

@angelo-fiorillo angelo-fiorillo angelo-fiorillo approved these changes

@Garma00 Garma00 Garma00 approved these changes

@giamma1295 giamma1295 Awaiting requested review from giamma1295 giamma1295 is a code owner automatically assigned from pagopa/io-backend-contributors

@arcogabbo arcogabbo Awaiting requested review from arcogabbo arcogabbo is a code owner automatically assigned from pagopa/io-backend-contributors

@rodoviti rodoviti Awaiting requested review from rodoviti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michaeldisaro @gunzip @iwoak @Garma00 @angelo-fiorillo