Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log email/webhook delivery errors in application insights exceptions #59

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Log email/webhook delivery errors in application insights exceptions #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion EmailNotificationActivity/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ export const getEmailNotificationActivityHandler = (
const error = sendResult.value;
// track the event of failed delivery
context.log.error(`${logPrefix}|ERROR=${error.message}`);
throw new Error("Error while sending email");
throw new Error(`Error while sending email: ${error.message}`);
}

context.log.verbose(`${logPrefix}|RESULT=SUCCESS`);
Expand Down
2 changes: 1 addition & 1 deletion WebhookNotificationActivity/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ export const getWebhookNotificationActivityHandler = (
const error = sendResult.value;
context.log.error(`${logPrefix}|ERROR=${error.message}`);
if (isTransientError(error)) {
throw new Error("Error while calling webhook");
throw new Error(`Error while calling webhook: ${error.message}`);
} else {
return WebhookNotificationActivityResult.encode({
kind: "FAILURE",
Expand Down