[#167569704] Add GetLimitedProfile function #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudify
suggested changes
Aug 18, 2019
GetLimitedProfile/handler.ts
Outdated
|
|
||
| /** | ||
| * Whether the sender service is allowed to send | ||
| * notififications to the user identified by this profile |
There was a problem hiding this comment.
Suggested change
| * notififications to the user identified by this profile | |
| * messages to the user identified by this profile |
GetLimitedProfile/handler.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * Converts the Profile model to LimetedProfile type. |
There was a problem hiding this comment.
Suggested change
| * Converts the Profile model to LimetedProfile type. | |
| * Converts the Profile model to LimitedProfile type. |
GetLimitedProfile/handler.ts
Outdated
|
|
||
| const middlewaresWrap = withRequestMiddlewares( | ||
| AzureApiAuthMiddleware( | ||
| new Set([UserGroup.ApiLimitedProfileRead, UserGroup.ApiFullProfileRead]) |
There was a problem hiding this comment.
since this API will be used only by 3rd party services, we can limit the groups to ApiLimitedProfileRead (ApiFullProfileRead is only used by the app backend)
Suggested change
| new Set([UserGroup.ApiLimitedProfileRead, UserGroup.ApiFullProfileRead]) | |
| new Set([UserGroup.ApiLimitedProfileRead]) |
| } from "../handler"; | ||
|
|
||
| describe("isSenderAllowed", () => { | ||
| it("should return false is the service is not allowed to send notifications to the user", () => { |
There was a problem hiding this comment.
Suggested change
| it("should return false is the service is not allowed to send notifications to the user", () => { | |
| it("should return false if the service is not allowed to send notifications to the user", () => { |
| expect(isAllowed).toBe(false); | ||
| }); | ||
|
|
||
| it("should return true is the service is allowed to send notifications to the user", () => { |
There was a problem hiding this comment.
Suggested change
| it("should return true is the service is allowed to send notifications to the user", () => { | |
| it("should return true if the service is allowed to send notifications to the user", () => { |
yes go ahead, thanks |
francescopersico
force-pushed
the
167569704-getlimitedprofile
branch
from
df80a3c to
ba354b0
Compare
Affected stories
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
==========================================
+ Coverage 73.33% 76.68% +3.35%
==========================================
Files 2 3 +1
Lines 150 193 +43
Branches 14 19 +5
==========================================
+ Hits 110 148 +38
- Misses 40 45 +5 |
cloudify
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because we need to decide how to handle the routes of the two http triggered functions.
For GetLimitedProfile i have set
v1/profiles/{fiscalCode}. If it is ok for you i can change the CreateMessage route from{*segments}tov1/messages/{fiscalCode}.