Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IOPID-1908] Add configuration for Profile change feed processor #1130

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

BurnedMarshal
Copy link
Contributor

⚠️ Depends on #1129

List of changes

Add configuration for the new Profile change feed processor:

  • lease name
  • event hub topic name and connection string
  • disable change feed trigger

Motivation and context

Add all the new required configuration to the environment of io-functions-elt for the profile change feed processor.
Temporary disable the new trigger, will be enabled when the integration with PDND will be completed.

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

How to apply

After PR is approved

  1. run deploy pipeline from Azure DevOps io-platform-iac-projects
  2. select PR branch
  3. wait for approval

Copy link

github-actions bot commented Aug 13, 2024

Terraform Plan ('src/domains/elt/prod/westeurope') 📖

Terraform Plan
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.function_apps.module.function_elt.azurerm_linux_function_app.this will be updated in-place
  ~ resource "azurerm_linux_function_app" "this" {
      ~ app_settings                                   = {
          + "AzureWebJobs.AnalyticsProfilesChangeFeedInboundProcessorAdapter.Disabled"           = "1"
          + "PROFILES_LEASES_PREFIX"                                                             = "profiles-001"
          + "PROFILES_TOPIC_CONNECTION_STRING"                                                   = (sensitive value)
          + "PROFILES_TOPIC_NAME"                                                                = "pdnd-io-cosmosdb-profiles"
            # (87 unchanged elements hidden)
        }
        id                                             = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-elt-rg/providers/Microsoft.Web/sites/io-p-fn-elt"
        name                                           = "io-p-fn-elt"
        tags                                           = {
            "CostCenter"                                     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"                                      = "Terraform"
            "Environment"                                    = "Prod"
            "ManagementTeam"                                 = "IO Platform"
            "Owner"                                          = "IO"
            "Source"                                         = "https://github.com/pagopa/io-infra/blob/main/src/domains/elt/prod"
        }
        # (27 unchanged attributes hidden)

      ~ site_config {
          ~ health_check_eviction_time_in_min       = 0 -> 10
            # (24 unchanged attributes hidden)

            # (8 unchanged blocks hidden)
        }

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Base automatically changed from IOPID-1918-profile-eventhub-topic to main August 14, 2024 08:03
Copy link

dpulls bot commented Aug 14, 2024

🎉 All dependencies have been resolved !

@BurnedMarshal BurnedMarshal force-pushed the IOPID-1977-add-profile-topic-fnelt-config branch from 2c8933f to 485d4cc Compare August 14, 2024 08:06
Copy link

@BurnedMarshal BurnedMarshal merged commit dccec08 into main Aug 14, 2024
6 checks passed
@BurnedMarshal BurnedMarshal deleted the IOPID-1977-add-profile-topic-fnelt-config branch August 14, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant