[#IOCIT-182] add fn public #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasqualedevita
requested changes
Dec 3, 2022
src/core/99_variables.tf
Outdated
| default = null | ||
| } | ||
|
|
||
| variable "plan_shared_sku_tier" { |
There was a problem hiding this comment.
Suggested change
| variable "plan_shared_sku_tier" { | |
| variable "plan_shared_1_sku_tier" { |
add 1 to respect naming convention, there are many others changes to do
src/core/99_variables.tf
Outdated
| @@ -222,6 +222,11 @@ variable "cidr_subnet_cgn" { | |||
| description = "Function cgn address space." | |||
| } | |||
|
|
|||
| variable "cidr_subnet_shared" { | |||
There was a problem hiding this comment.
Suggested change
| variable "cidr_subnet_shared" { | |
| variable "cidr_subnet_shared_1" { |
arcogabbo
commented
Dec 6, 2022
pasqualedevita
previously approved these changes
Dec 6, 2022
michaeldisaro
previously approved these changes
Dec 19, 2022
src/core/function_public.tf
Outdated
| function_public = { | ||
| app_settings_common = { | ||
| FUNCTIONS_WORKER_RUNTIME = "node" | ||
| WEBSITE_NODE_DEFAULT_VERSION = "14.16.0" |
pasqualedevita
requested changes
Dec 19, 2022
src/core/function_public.tf
Outdated
| resource_group_name = azurerm_resource_group.shared_rg.name | ||
| function_app_name = module.function_public.name | ||
| function_app_id = module.function_public.id | ||
| app_service_plan_id = azurerm_app_service_plan.shared_1_plan.id |
There was a problem hiding this comment.
Suggested change
| app_service_plan_id = azurerm_app_service_plan.shared_1_plan.id | |
| app_service_plan_id = azurerm_app_service_plan.shared_1_plan.id |
There was a problem hiding this comment.
what is the difference?
pasqualedevita
approved these changes
Dec 19, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
function_publicwith azure functions runtime v4shared_plan_1service planMotivation and context
porting from old infrastructure and various improvements
Type of changes
Env to apply
Does this introduce a change to production resources with possible user impact?
Does this introduce an unwanted change on infrastructure? Check terraform plan execution result
Other information
If PR is partially applied, why? (reserved to mantainers)
How to apply
After PR is approved