Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move redis to citizen-auth-common domain #723

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Move redis to citizen-auth-common domain #723

merged 2 commits into from
Oct 30, 2023

Conversation

gquadrati
Copy link
Contributor

List of changes

  • Move redis to citizen-auth-common domain

Motivation and context

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information

If PR is partially applied, why? (reserved to mantainers)

How to apply

After PR is approved

  1. run deploy pipeline from Azure DevOps io-platform-iac-projects
  2. select PR branch
  3. wait for approval

@gquadrati gquadrati requested a review from a team October 30, 2023 17:09
@gquadrati gquadrati requested review from a team as code owners October 30, 2023 17:09
@gquadrati gquadrati temporarily deployed to prod-runner October 30, 2023 17:09 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci October 30, 2023 17:10 — with GitHub Actions Inactive
BurnedMarshal
BurnedMarshal approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gquadrati gquadrati temporarily deployed to prod-runner October 30, 2023 17:13 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gquadrati gquadrati temporarily deployed to prod-ci October 30, 2023 17:14 — with GitHub Actions Inactive
@gquadrati gquadrati merged commit a18d980 into main Oct 30, 2023
6 checks passed
@gquadrati gquadrati deleted the fix-redis-common branch October 30, 2023 17:17
@gquadrati gquadrati temporarily deployed to prod-runner October 30, 2023 17:19 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurnedMarshal BurnedMarshal BurnedMarshal approved these changes

@diegolagospagopa diegolagospagopa Awaiting requested review from diegolagospagopa

@Krusty93 Krusty93 Awaiting requested review from Krusty93 Krusty93 is a code owner automatically assigned from pagopa/io-backend-contributors

@AleDore AleDore Awaiting requested review from AleDore AleDore is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gquadrati @BurnedMarshal