Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: semantic and structural error #93

Closed
wants to merge 2 commits into from
Closed

fix: semantic and structural error #93

wants to merge 2 commits into from

Conversation

aymen94
Copy link
Contributor

@aymen94 aymen94 commented May 8, 2019

Fix Error #92

  • add multipart/form-data
  • fixdecription to description
  • change oneOf to allOf

This is for Google Summer of Code

src/__tests__/api.yaml Outdated Show resolved Hide resolved
@cloudify
Copy link
Contributor

cloudify commented May 9, 2019

thanks @aymen94 , I just gave you write permission on this repo, would you mind re-creating this PR from a branch in this repo (the circleci checks don't run on forks) - thanks

@cloudify
Copy link
Contributor

cloudify commented May 9, 2019

@ioggstream that's fine with with me, just we can't merge it to master now, I would suggest to create an oas3 branch from the current master and change this PR to be against that branch - once the oas3 branch is stable and complete we can merge it to master.

I suggest to create also a DRAFT PR from oas3 to master to get circleci validate the changes.

@ioggstream
Copy link

@cloudify we could

1- split this PR fixing description and multipart: those two should be mergeable
2- leave the rest in the OAS3 fork

Sounds good?

@aymen94
Copy link
Contributor Author

aymen94 commented May 9, 2019

@cloudify thank for permission.
@ioggstream ok, I make.

@aymen94 aymen94 closed this May 9, 2019
@aymen94 aymen94 mentioned this pull request May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants