Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: P4ADEV-2134 align installment status #63

Merged
merged 44 commits into from
Feb 18, 2025
Merged

feat: P4ADEV-2134 align installment status #63

merged 44 commits into from
Feb 18, 2025

Conversation

serdimic
Copy link
Collaborator

Description

align installment status

List of Changes

align installment status of debt position associated to receipt

Motivation and Context

process received receipt from PagoPA

How Has This Been Tested?

  • Pre-Deploy Test
    • Unit
    • Integration (Narrow)
  • Post-Deploy Test
    • Isolated Microservice
    • Broader Integration
    • Acceptance
    • Performance & Load

Types of changes

  • PATCH - Bug fix (backwards compatible bug fixes)
  • MINOR - New feature (add functionality in a backwards compatible manner)
  • MAJOR - Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CHORE - Minor Change (fix or feature that don't impact the functionality e.g. Documentation or lint configuration)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@serdimic
P4ADEV-2134 align installment status
3246532
@serdimic
Merge branch 'develop' into P4ADEV-2134-align_installment_status
f4925c8
@serdimic
P4ADEV-2134 merge BrokerService into single class
3f1b2ff
@serdimic
P4ADEV-2134 update generated.openapi.json
987ca2a
@serdimic
P4ADEV-2134 complete implementation of update installment status
9eccdd0
@serdimic
Merge branch 'develop' into P4ADEV-2134-align_installment_status
8219f45
@serdimic
P4ADEV-2134 update ReceiptServiceImpl for new interface of DebtPositi…
03b326b 
…onSyncService.invokeWorkFlow
@serdimic
P4ADEV-2134 update generated.openapi.json
4f76b5e
@serdimic
Merge branch 'develop' into P4ADEV-2134-align_installment_status
f1ddd21
@serdimic
Merge branch 'develop' into P4ADEV-2134-align_installment_status
cf19558
@serdimic
Merge branch 'develop' into P4ADEV-2134-align_installment_status
06827d4
@serdimic
P4ADEV-2134 align installment status of debt position associated to r…
9eae5b1 
…eceipt
@serdimic
Merge branch 'develop' into P4ADEV-2134-align_installment_status
c846fc3
@serdimic
P4ADEV-2134 fix typo in ReceiptNoPIIRepository
31d10a1
@serdimic
P4ADEV-2134 fix DebtPositionDTO.status in ReceiptServiceImplTest
9670d28
@serdimic
P4ADEV-2134 fix code style issue in BrokerServiceTest
fbfe113
@serdimic serdimic marked this pull request as ready for review February 12, 2025 21:15
antonioT90
antonioT90 requested changes Feb 14, 2025
View reviewed changes
.../java/it/gov/pagopa/pu/debtpositions/exception/custom/InvalidInstallmentStatusException.java Show resolved Hide resolved
src/main/java/it/gov/pagopa/pu/debtpositions/service/ReceiptServiceImpl.java Outdated Show resolved Hide resolved
...ain/java/it/gov/pagopa/pu/debtpositions/service/create/receipt/CreateReceiptServiceImpl.java Outdated Show resolved Hide resolved
...ain/java/it/gov/pagopa/pu/debtpositions/service/create/receipt/CreateReceiptServiceImpl.java Outdated Show resolved Hide resolved
...ain/java/it/gov/pagopa/pu/debtpositions/service/create/receipt/CreateReceiptServiceImpl.java Outdated Show resolved Hide resolved
...ain/java/it/gov/pagopa/pu/debtpositions/service/create/receipt/CreateReceiptServiceImpl.java Outdated Show resolved Hide resolved
...ain/java/it/gov/pagopa/pu/debtpositions/service/create/receipt/InstallmentUpdateService.java Outdated Show resolved Hide resolved
...java/it/gov/pagopa/pu/debtpositions/service/create/receipt/InstallmentUpdateServiceImpl.java Outdated Show resolved Hide resolved
...java/it/gov/pagopa/pu/debtpositions/service/create/receipt/InstallmentUpdateServiceImpl.java Outdated Show resolved Hide resolved
...java/it/gov/pagopa/pu/debtpositions/service/create/receipt/InstallmentUpdateServiceImpl.java Outdated Show resolved Hide resolved
antonioT90
antonioT90 requested changes Feb 14, 2025
View reviewed changes
.../it/gov/pagopa/pu/debtpositions/service/create/receipt/PrimaryOrgInstallmentServiceImpl.java Outdated Show resolved Hide resolved
.../it/gov/pagopa/pu/debtpositions/service/create/receipt/PrimaryOrgInstallmentServiceImpl.java Outdated Show resolved Hide resolved
...ain/java/it/gov/pagopa/pu/debtpositions/service/create/receipt/CreateReceiptServiceImpl.java Outdated Show resolved Hide resolved
...java/it/gov/pagopa/pu/debtpositions/service/create/receipt/InstallmentUpdateServiceImpl.java Outdated Show resolved Hide resolved
...java/it/gov/pagopa/pu/debtpositions/service/create/receipt/InstallmentUpdateServiceImpl.java Outdated Show resolved Hide resolved
...java/it/gov/pagopa/pu/debtpositions/service/create/receipt/InstallmentUpdateServiceImpl.java Outdated Show resolved Hide resolved
...java/it/gov/pagopa/pu/debtpositions/service/create/receipt/PrimaryOrgInstallmentService.java Outdated Show resolved Hide resolved
...java/it/gov/pagopa/pu/debtpositions/service/create/receipt/PrimaryOrgInstallmentService.java Outdated Show resolved Hide resolved
@serdimic
P4ADEV-2134 rename PrimaryOrgInstallmentPaidVerifierService and fix b…
9d8ed49 
…usiness logic to determine whether primaryOrgInstallment is found
@serdimic
P4ADEV-2134
0c7b7e5 
- InstallmentNoPIIRepository.getByOrganizationIdAndNav accept debtPositionOrigin input param;
- use it on PrimaryOrgInstallmentPaidVerifierService to filter the installments only on ordinary debt positions
@serdimic
P4ADEV-2134 split CreateReceiptServiceImpl on class UpdatePaidDebtPos…
68bea4e 
…itionService
@serdimic
P4ADEV-2134 add comment in PrimaryOrgInstallmentPaidVerifierService
5ce83d7
@serdimic
P4ADEV-2134 persist DebtPosition of primary org
12f8a47
@serdimic
P4ADEV-2134 refactor InstallmentUpdateService and UpdatePaidDebtPosit…
422b232 
…ionService to take into account the new logic regarding TO_SYNC status (i.e. even when broker use the SYNC interaction model, the new installment status will be TO_SYNC)
@serdimic
Merge branch 'develop' into P4ADEV-2134-align_installment_status
b6cb25b
antonioT90
antonioT90 requested changes Feb 17, 2025
View reviewed changes
...pagopa/pu/debtpositions/service/create/receipt/PrimaryOrgInstallmentPaidVerifierService.java Outdated Show resolved Hide resolved
...pagopa/pu/debtpositions/service/create/receipt/PrimaryOrgInstallmentPaidVerifierService.java Outdated Show resolved Hide resolved
...pagopa/pu/debtpositions/service/create/receipt/PrimaryOrgInstallmentPaidVerifierService.java Outdated Show resolved Hide resolved
...ava/it/gov/pagopa/pu/debtpositions/service/create/receipt/UpdatePaidDebtPositionService.java Outdated Show resolved Hide resolved
...ava/it/gov/pagopa/pu/debtpositions/service/create/receipt/UpdatePaidDebtPositionService.java Outdated Show resolved Hide resolved
...java/it/gov/pagopa/pu/debtpositions/service/create/receipt/InstallmentUpdateServiceImpl.java Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
97.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@serdimic serdimic merged commit 692f6e1 into develop Feb 18, 2025
12 of 13 checks passed
@serdimic serdimic deleted the P4ADEV-2134-align_installment_status branch February 18, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertopasetti robertopasetti robertopasetti left review comments

@antonioT90 antonioT90 antonioT90 approved these changes

@antocalo antocalo Awaiting requested review from antocalo antocalo is a code owner

@Benedetta-fabbri Benedetta-fabbri Awaiting requested review from Benedetta-fabbri Benedetta-fabbri is a code owner

@LarissaASLeite LarissaASLeite Awaiting requested review from LarissaASLeite LarissaASLeite is a code owner

@RiccardoGiuliani RiccardoGiuliani Awaiting requested review from RiccardoGiuliani RiccardoGiuliani is a code owner

@MScarsella MScarsella Awaiting requested review from MScarsella MScarsella is a code owner

@ElisKina-dev ElisKina-dev Awaiting requested review from ElisKina-dev ElisKina-dev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serdimic @antonioT90 @robertopasetti