feat: P4ADEV-1639 wf iuv classification activity implementation classify iuv activity retrieve iuv

src/main/java/it/gov/pagopa/payhub/activities/activity/classifications/TransferClassificationActivity.java

@@ -9,14 +9,14 @@
 @ActivityInterface
 public interface TransferClassificationActivity {
 
-    /**
-     * Processes Transfer classification based on the provided parameters.
-     *
-     * @param orgId the unique identifier of the organization
-     * @param iuv   the unique identifier of the payment (IUV)
-     * @param iur   the identifier of the receipt associated with the payment
-     * @param transferIndex  the index of the transfer to be classified
-     */
-    @ActivityMethod
-    void classify(Long orgId, String iuv, String iur, int transferIndex);
+	/**
+	 * Processes Transfer classification based on the provided parameters.
+	 *
+	 * @param orgId the unique identifier of the organization
+	 * @param iuv   the unique identifier of the payment (IUV)
+	 * @param iur   the identifier of the receipt associated with the payment
+	 * @param transferIndex  the index of the transfer to be classified
+	 */
+	@ActivityMethod
+	void classify(Long orgId, String iuv, String iur, int transferIndex);
 }

src/main/java/it/gov/pagopa/payhub/activities/activity/classifications/TransferClassificationActivityImpl.java

@@ -1,6 +1,7 @@
 package it.gov.pagopa.payhub.activities.activity.classifications;
 
 import it.gov.pagopa.payhub.activities.dao.ClassificationDao;
+import it.gov.pagopa.payhub.activities.dao.TransferDao;
 import it.gov.pagopa.payhub.activities.exception.ClassificationException;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.context.annotation.Lazy;
@@ -11,9 +12,12 @@
 @Component
 public class TransferClassificationActivityImpl implements TransferClassificationActivity {
 	private final ClassificationDao classificationDao;
+	private final TransferDao transferDao;
 
-	public TransferClassificationActivityImpl(ClassificationDao classificationDao) {
+	public TransferClassificationActivityImpl(ClassificationDao classificationDao,
+	                                          TransferDao transferDao) {
 		this.classificationDao = classificationDao;
+		this.transferDao = transferDao;
 	}
 
 	@Override
@@ -22,6 +26,6 @@ public void classify(Long orgId, String iuv, String iur, int transferIndex) {
 		if (!classificationDao.deleteTransferClassification(orgId, iuv, iur, transferIndex)) {
 			throw new ClassificationException("Error occurred while clean up current processing Requests due to failed deletion");
 		}
+		transferDao.findBySemanticKey(orgId, iuv, iur, transferIndex);
 	}
-
 }

src/main/java/it/gov/pagopa/payhub/activities/dao/TransferDao.java

@@ -0,0 +1,16 @@
+package it.gov.pagopa.payhub.activities.dao;
+
+import it.gov.pagopa.payhub.activities.dto.TransferDTO;
+
+import java.util.List;
+
+/**
+ * Data Access Object (DAO) interface for handling operations related to
+ * `Transfer` objects.
+ *
+ * @see TransferDTO
+ */
+public interface TransferDao {
+
+	TransferDTO findBySemanticKey(Long orgId, String iuv, String iur, int transferIndex);
+}

src/test/java/it/gov/pagopa/payhub/activities/activity/classifications/TransferClassificationActivityImplTest.java

@@ -1,13 +1,17 @@
 package it.gov.pagopa.payhub.activities.activity.classifications;
 
 import it.gov.pagopa.payhub.activities.dao.ClassificationDao;
+import it.gov.pagopa.payhub.activities.dao.TransferDao;
+import it.gov.pagopa.payhub.activities.dto.TransferDTO;
 import it.gov.pagopa.payhub.activities.exception.ClassificationException;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
 
+import java.util.List;
+
 import static org.junit.jupiter.api.Assertions.*;
 import static org.mockito.Mockito.when;
 
@@ -21,22 +25,33 @@ class TransferClassificationActivityImplTest {
 	@Mock
 	private ClassificationDao classificationDaoMock;
 
+	@Mock
+	private TransferDao transferDaoMock;
+
 	private TransferClassificationActivity activity;
 
 	@BeforeEach
 	void setUp() {
-		activity = new TransferClassificationActivityImpl(classificationDaoMock);
+		activity = new TransferClassificationActivityImpl(classificationDaoMock, transferDaoMock);
 	}
 
 	@Test
 	void classificationSuccess() {
 		when(classificationDaoMock.deleteTransferClassification(ORGANIZATION, IUV, IUR, INDEX)).thenReturn(Boolean.TRUE);
+		when(transferDaoMock.retrieveTransferByLogicalKey(ORGANIZATION, IUV, IUR, INDEX)).thenReturn(List.of(new TransferDTO()));
 		assertDoesNotThrow(() -> activity.classify(ORGANIZATION, IUV, IUR, INDEX));
 	}
 
 	@Test
-	void classificationFailed() {
+	void givenFailedDeletePreviousClassificationWhenClassifyThenClassificationFailed() {
 		when(classificationDaoMock.deleteTransferClassification(ORGANIZATION, IUV, IUR, INDEX)).thenReturn(Boolean.FALSE);
 		assertThrows(ClassificationException.class, () -> activity.classify(ORGANIZATION, IUV, IUR, INDEX), "classification failed");
 	}
+
+	@Test
+	void givenFailedFindTransferWhenClassifyThenClassificationFailed() {
+		when(classificationDaoMock.deleteTransferClassification(ORGANIZATION, IUV, IUR, INDEX)).thenReturn(Boolean.TRUE);
+		when(transferDaoMock.findBySemanticKey(ORGANIZATION, IUV, IUR, INDEX)).thenThrow(new ClassificationException("retrieving failed"));
+		assertThrows(ClassificationException.class, () -> activity.classify(ORGANIZATION, IUV, IUR, INDEX), "classification failed");
+	}
 }

version

@@ -1 +1 @@
-1.19.0
+1.19.0-SNAPSHOT