Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:[PAGOPA-2362] Manage schema v1 #76

Merged
merged 71 commits into from
Dec 18, 2024
Merged

feat:[PAGOPA-2362] Manage schema v1 #76

merged 71 commits into from
Dec 18, 2024

Conversation

aomegax
Copy link
Contributor

@aomegax aomegax commented Nov 18, 2024

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@aomegax aomegax self-assigned this Nov 18, 2024
@aomegax aomegax marked this pull request as ready for review December 18, 2024 21:02
@aomegax aomegax requested a review from a team as a code owner December 18, 2024 21:02
FedericoRuzzier
FedericoRuzzier approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@FedericoRuzzier FedericoRuzzier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
60.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@FedericoRuzzier FedericoRuzzier merged commit 183c621 into main Dec 18, 2024
8 of 10 checks passed
@FedericoRuzzier FedericoRuzzier deleted the PAGOPA-2362-schema-v1 branch December 18, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedericoRuzzier FedericoRuzzier FedericoRuzzier approved these changes

Assignees

@aomegax aomegax

Labels
size/large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aomegax @FedericoRuzzier @pagopa-github-bot