Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging #19

Merged
merged 7 commits into from
Mar 25, 2022
Merged

Logging #19

merged 7 commits into from
Mar 25, 2022

Conversation

pasqualespica
Copy link
Contributor

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

94.1% 94.1% Coverage
0.0% 0.0% Duplication

@pasqualespica pasqualespica marked this pull request as ready for review March 25, 2022 07:47
@pasqualespica pasqualespica requested review from a team, aomegax and jacopocarlini March 25, 2022 07:47
jacopocarlini
jacopocarlini approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@jacopocarlini jacopocarlini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@jacopocarlini jacopocarlini merged commit 992c675 into main Mar 25, 2022
@jacopocarlini jacopocarlini deleted the logging branch March 25, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacopocarlini jacopocarlini jacopocarlini approved these changes

@aomegax aomegax Awaiting requested review from aomegax

Assignees

@aomegax aomegax

@jacopocarlini jacopocarlini

@pasqualespica pasqualespica

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pasqualespica @jacopocarlini @aomegax