Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add debtor-fiscal-code validation [PAGOPA-1649] #50

Merged
merged 2 commits into from
Apr 3, 2024
Merged

fix: add debtor-fiscal-code validation [PAGOPA-1649] #50

merged 2 commits into from
Apr 3, 2024

Conversation

cap-ang
Copy link
Contributor

@cap-ang cap-ang commented Apr 3, 2024 •
edited
Loading

List of Changes

  • debtor-fiscal-code validation was added: the field debtor_id_fiscal_code length must be equal to 11 characters.

Motivation and Context

  • Prevents wrong data entry

How Has This Been Tested?

  • The fix was tested in DEV environment

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cap-ang cap-ang requested a review from pasqualespica April 3, 2024 07:36
@cap-ang cap-ang self-assigned this Apr 3, 2024
pasqualespica
pasqualespica approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO

@cap-ang cap-ang changed the title feat: add debtor-fiscal-code validation [PAGOPA-1649] fix: add debtor-fiscal-code validation [PAGOPA-1649] Apr 3, 2024
@cap-ang cap-ang merged commit 9a26726 into main Apr 3, 2024
6 of 7 checks passed
@cap-ang cap-ang deleted the PAGOPA-1649-add-debtor-fiscal-code-validation branch April 3, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@cap-ang cap-ang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cap-ang @pasqualespica