Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [PAGOPA-2359] - serviceType field #29

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: [PAGOPA-2359] - serviceType field #29

wants to merge 10 commits into from

Conversation

alessio-acitelli
Copy link

@alessio-acitelli alessio-acitelli commented Nov 27, 2024 •
edited
Loading

List of Changes

  • refactored code for new serviceType field

Motivation and Context

  • introduced new field to identify debt positions

How Has This Been Tested?

  • manual and junit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

aacitelli added 2 commits November 27, 2024 17:06
[PAGOPA-2359] sonar coverage
77cd8e2
Merge branch 'PAGOPA-2359-exclude-WISP' of
0305242 
https://github.com/pagopa/pagopa-gpd-payments-pull into
PAGOPA-2359-exclude-WISP

Conflicts:
	src/main/java/it/gov/pagopa/gpd/payments/pull/repository/PaymentPositionRepository.java
aacitelli added 2 commits November 27, 2024 17:32
[PAGOPA-2359] sonar coverage
858f15c
Merge branch 'PAGOPA-2359-exclude-WISP' of
a6febfe 
https://github.com/pagopa/pagopa-gpd-payments-pull into
PAGOPA-2359-exclude-WISP

Conflicts:
	src/main/java/it/gov/pagopa/gpd/payments/pull/repository/PaymentPositionRepository.java
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@alessio-acitelli alessio-acitelli marked this pull request as ready for review November 27, 2024 16:37
cap-ang
cap-ang requested changes Nov 27, 2024
View reviewed changes
Copy link

@cap-ang cap-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, just some doubts.
With this change (if I am not mistaken) we avoid showing WISP debt positions and it is correct

Could we test at least in DEV environment before merge it?

src/main/java/it/gov/pagopa/gpd/payments/pull/models/PaymentNotice.java Show resolved Hide resolved
src/main/java/it/gov/pagopa/gpd/payments/pull/models/PaymentNotice.java Outdated Show resolved Hide resolved
@alessio-acitelli
Copy link
Author

Good work, just some doubts. With this change (if I am not mistaken) we avoid showing WISP debt positions and it is correct

Could we test at least in DEV environment before merge it?

I did some tests locally but no problem deploying in DEV. Before doing so, I would say to wait until the alignment task of the previous PAGOPA-2427 has been done

jacopocarlini
jacopocarlini approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@jacopocarlini jacopocarlini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work! 👍

@pasqualespica pasqualespica changed the title feat: [PAGOPA-2359] - serviceType field feat: [PAGOPA-2359] - migration serviceType field Dec 6, 2024
@pasqualespica pasqualespica changed the title feat: [PAGOPA-2359] - migration serviceType field feat: [PAGOPA-2359] - serviceType field Dec 6, 2024
@pasqualespica pasqualespica added documentation Improvements or additions to documentation dev labels Dec 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

This pull request does not contain a valid label. Please add one of the following labels: [major, minor, patch, patch, skip]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

@jacopocarlini jacopocarlini jacopocarlini approved these changes

@alessio-cialini alessio-cialini Awaiting requested review from alessio-cialini alessio-cialini is a code owner

@svariant svariant Awaiting requested review from svariant svariant is a code owner

@gioelemella gioelemella Awaiting requested review from gioelemella gioelemella is a code owner

@cap-ang cap-ang Awaiting requested review from cap-ang

Requested changes must be addressed to merge this pull request.

Assignees

@alessio-acitelli alessio-acitelli

Labels
dev documentation Improvements or additions to documentation size/small uat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio-acitelli @jacopocarlini @pasqualespica @cap-ang