Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gpd-reporting-analysis housekeeping [PAGOPA-701 ] #3

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

cap-ang
Copy link
Contributor

@cap-ang cap-ang commented Apr 21, 2023

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cap-ang cap-ang added the ignore-for-release Ignore pull request from the release label Apr 21, 2023
@cap-ang cap-ang self-assigned this Apr 21, 2023
@cap-ang cap-ang requested a review from a team as a code owner April 21, 2023 10:26
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

79.4% 79.4% Coverage
0.0% 0.0% Duplication

Logger logger = Logger.getLogger("testlogging");

String storageConnectionString = String.format(
"DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://%s:%s/devstoreaccount1;TableEndpoint=http://%s:%s/devstoreaccount1",

Check failure

Code scanning / SonarCloud

Azure Storage Account Keys should not be disclosed

<!--SONAR_ISSUE_KEY:AYejfeuMxZTizGEJ909C-->Make sure this Azure Storage Account Key is not disclosed. <p>See more on <a href="https://sonarcloud.io/project/issues?id=pagopa_pagopa-gpd-reporting-analysis&issues=AYejfeuMxZTizGEJ909C&open=AYejfeuMxZTizGEJ909C&pullRequest=3">SonarCloud</a></p>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alert dismissed because storageConnectionString is the emulator connection string value, used only for local test.
For more info see: https://learn.microsoft.com/en-us/azure/storage/common/storage-use-emulator

Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 💪

@pasqualespica pasqualespica merged commit a815597 into main Apr 26, 2023
@pasqualespica pasqualespica deleted the PAGOPA-701-gpd-reporting-analysis-housekeeping branch April 26, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Ignore pull request from the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants