Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deploy pipeline #5

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Fix deploy pipeline #5

merged 3 commits into from
Apr 28, 2023

Conversation

cap-ang
Copy link
Contributor

@cap-ang cap-ang commented Apr 28, 2023

List of Changes

  • add waitForApprovalPROD and completeProdDeployFn to complete function deploy in prod
  • fix make_release job when SEMVER not equals skip

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cap-ang cap-ang added the bug Something isn't working label Apr 28, 2023
@cap-ang cap-ang self-assigned this Apr 28, 2023
@cap-ang cap-ang requested a review from a team as a code owner April 28, 2023 08:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pasqualespica pasqualespica merged commit 0e71e69 into main Apr 28, 2023
@pasqualespica pasqualespica deleted the fix-deploy-pipeline branch April 28, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@cap-ang cap-ang

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cap-ang @pasqualespica