Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repository): Use cosmos patch operations and fix response detail #22

Merged
merged 19 commits into from
Jun 11, 2024

Conversation

cap-ang
Copy link
Contributor

@cap-ang cap-ang commented Jun 7, 2024

List of Changes

Motivation and Context

  • The PR wants fix poorly aggregated responses and use CosmosPatchOperation when possible

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cap-ang cap-ang self-assigned this Jun 7, 2024
@cap-ang cap-ang marked this pull request as ready for review June 7, 2024 15:03
@cap-ang cap-ang requested a review from a team as a code owner June 7, 2024 15:03
@cap-ang cap-ang changed the title feat(repository): Use cosmos patch operations and Fix response detail feat(repository): Use cosmos patch operations and fix response detail Jun 10, 2024
Copy link
Contributor

@FedericoRuzzier FedericoRuzzier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@FedericoRuzzier
Copy link
Contributor

Fix sonar then good to go

Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@cap-ang cap-ang merged commit ed8a8f1 into main Jun 11, 2024
8 of 9 checks passed
@cap-ang cap-ang deleted the PAGOPA-1787-cosmos-operation-refactoring branch June 11, 2024 13:49
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
77.6% Coverage on New Code (required ≥ 80%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants