Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PPANTT-197] feat: Add integration test #5

Merged
merged 15 commits into from
Dec 10, 2024

Conversation

gioelemella
Copy link
Collaborator

@gioelemella gioelemella commented Dec 5, 2024

List of Changes

  • added integration test project
  • fixed models and converter

Apply:

  • DEV
  • UAT
  • PROD

Motivation and Context

PPANTT-197

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

private String debtorFiscalCode;

@NotBlank(message = "Fiscal code must be not empty")
@Schema(description = "Creditor Institution's fiscal code", requiredMode = Schema.RequiredMode.REQUIRED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[google-java-format] reported by reviewdog 🐶

Suggested change
@Schema(description = "Creditor Institution's fiscal code", requiredMode = Schema.RequiredMode.REQUIRED)
@Schema(
description = "Creditor Institution's fiscal code",
requiredMode = Schema.RequiredMode.REQUIRED)

@pasqualespica pasqualespica force-pushed the PPANTT-197-e-bollo-2-0-integration-test-mdb-gps branch from 9a25035 to 3dd8f69 Compare December 10, 2024 14:22
Copy link
Contributor

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@pasqualespica pasqualespica merged commit 9ddfb0f into main Dec 10, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants