Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAS-1149] fix: Wrapper channel raw generic #448

Merged
merged 2 commits into from
Jun 27, 2024
Merged

[VAS-1149] fix: Wrapper channel raw generic #448

merged 2 commits into from
Jun 27, 2024

Conversation

gioelemella
Copy link
Collaborator

List of Changes

  • avoid the raw usage of generics in channels api

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gioelemella gioelemella added bug Something isn't working patch labels Jun 27, 2024
@gioelemella gioelemella requested review from alessio-cialini, svariant and a team as code owners June 27, 2024 14:53
svariant
svariant approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@svariant svariant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️

@gioelemella gioelemella merged commit bb45635 into next Jun 27, 2024
15 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jacopocarlini jacopocarlini deleted the VAS-1149-fix-wrapper-channel-raw-generic branch July 2, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svariant svariant svariant approved these changes

@alessio-cialini alessio-cialini Awaiting requested review from alessio-cialini alessio-cialini is a code owner

Assignees

@gioelemella gioelemella

Labels
bug Something isn't working patch size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gioelemella @svariant