Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improvements on RE events info #182

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Conversation

andrea-deri
Copy link
Contributor

@andrea-deri andrea-deri commented Nov 26, 2024

This PR contains several changes made in order to improve some information included in RE event. These changes permits to improve the reliability of RE event info in order to perform better tracking.

List of Changes

  • Resolved wrong generation of response payload on client invocation
  • Included correct handling of IUV and notice number codes in GPD and IUVGenerator clients

Motivation and Context

These changes are required in order to improve the quality of the information included in RE events.

How Has This Been Tested?

Tested in local environment

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@andrea-deri andrea-deri requested a review from a team as a code owner November 26, 2024 12:05
Copy link

This pull request does not contain a valid label. Please add one of the following labels: [patch, ignore-for-release]

Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

@andrea-deri andrea-deri changed the title fix: resolved wrong generation of response payload on client invocation fix: improvements on RE events info Dec 16, 2024
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@pasqualespica pasqualespica merged commit b518761 into main Dec 17, 2024
6 of 8 checks passed
@pasqualespica pasqualespica deleted the fix-responsepayload-in-re branch December 17, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants