Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAGOPA-1894] fix: refactored sessionID setting #13

Merged
merged 9 commits into from
Jul 3, 2024

Conversation

andrea-deri
Copy link

This PR contains a change made on sessionID setting. The set is required because previously the value was set with the operationId's UUID value but it was not correct because it was impossible to trace in the whole request.

List of Changes

  • Refactored sessionId setting

Motivation and Context

How Has This Been Tested?

  • Tested in DEV environment
  • Tested in UAT environment

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

sonarqubecloud bot commented Jul 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
47.8% Coverage on New Code (required ≥ 80%)
25.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

@FedericoRuzzier FedericoRuzzier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@andrea-deri andrea-deri merged commit 67a328a into main Jul 3, 2024
3 checks passed
@andrea-deri andrea-deri deleted the PAGOPA-1894-fix-sessionId branch July 3, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants