Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

[SELC-4929] refactor: Replace Notification Manager with AWS SDK #496

Merged
merged 4 commits into from
May 20, 2024

Conversation

manuraf
Copy link
Contributor

@manuraf manuraf commented May 20, 2024

List of Changes

  • Integrated AWS SDK for sending emails, replacing the existing mechanism that relied on the notification-manager microservice.
  • Adjusted configuration and environment settings to support AWS SDK integration.

Motivation and Context

This pull request introduces two major changes aimed at optimizing the onboarding process and deprecating the notification-manager microservice:

1. Removal of Unused Variables:

Cleaned up the codebase by eliminating variables that are no longer used in the onboarding process. This helps in reducing clutter and potential confusion in the code.

2. Replacement of Email Sending Functionality:

Replaced the email sending functionality previously handled by the notification-manager microservice with AWS SDK.
This change is part of our effort to phase out the notification-manager microservice and streamline our notification system.

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@manuraf manuraf requested a review from a team as a code owner May 20, 2024 11:14
Copy link

@manuraf manuraf merged commit f6baf2d into main May 20, 2024
6 checks passed
@manuraf manuraf deleted the feature/SELC-4929-remove-notification-ms branch May 20, 2024 12:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant