This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
[SELC-5170] feat : API persists the DELETE logic of an onboarding with the corresponding physical removal of the PecNotification record #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fication && Added Junit test
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../dao/src/main/java/it/pagopa/selfcare/mscore/connector/dao/PecNotificationConnectorImpl.java
Dismissed
Show dismissed
Hide dismissed
.../dao/src/main/java/it/pagopa/selfcare/mscore/connector/dao/PecNotificationConnectorImpl.java
Dismissed
Show dismissed
Hide dismissed
.../dao/src/main/java/it/pagopa/selfcare/mscore/connector/dao/PecNotificationConnectorImpl.java
Dismissed
Show dismissed
Hide dismissed
.../dao/src/main/java/it/pagopa/selfcare/mscore/connector/dao/PecNotificationConnectorImpl.java
Dismissed
Show dismissed
Hide dismissed
.../dao/src/main/java/it/pagopa/selfcare/mscore/connector/dao/PecNotificationConnectorImpl.java
Dismissed
Show dismissed
Hide dismissed
.../dao/src/main/java/it/pagopa/selfcare/mscore/connector/dao/PecNotificationConnectorImpl.java
Dismissed
Show dismissed
Hide dismissed
eugenbegiqi
changed the title
manuraf
suggested changes
Jul 5, 2024
web/src/main/java/it/pagopa/selfcare/mscore/web/controller/InstitutionController.java
Outdated
Show resolved
Hide resolved
core/src/main/java/it/pagopa/selfcare/mscore/core/OnboardingServiceImpl.java
Outdated
Show resolved
Hide resolved
...n/java/it/pagopa/selfcare/mscore/connector/dao/model/mapper/PecNotificationEntityMapper.java
Outdated
Show resolved
Hide resolved
.../dao/src/main/java/it/pagopa/selfcare/mscore/connector/dao/PecNotificationConnectorImpl.java
Outdated
Show resolved
Hide resolved
.../dao/src/main/java/it/pagopa/selfcare/mscore/connector/dao/PecNotificationConnectorImpl.java
Outdated
Show resolved
Hide resolved
|
manuraf
approved these changes
Jul 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
API persists the DELETE logic of an onboarding with the corresponding physical removal of the PecNotification record.
When an institution is no longer onboarded on a product, the system must not send pec emails.
How Has This Been Tested?
Junit test and local test.
Screenshots (if appropriate):
Checklist: