[SELC-5216] feat: Added parentDescription to InstitutionOnboardings r…

…esponse (#330) Co-authored-by: Manuel Rafeli <manuel.rafeli@pagopa.it> Co-authored-by: pierpaolo.didato@emeal.nttdata.com <Aiap1955?^@#>
pagopa · Jul 5, 2024 · d0bd274 · d0bd274
1 parent c770ead
commit d0bd274
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 3 deletions.
diff --git a/app/src/main/resources/swagger/api-docs.json b/app/src/main/resources/swagger/api-docs.json
@@ -3389,6 +3389,10 @@
             "type" : "string",
             "description" : "Institution's details origin Id"
           },
+          "parentDescription" : {
+            "type" : "string",
+            "description" : "Institution's parent description"
+          },
           "taxCode" : {
             "type" : "string",
             "description" : "Institution's taxCode"

diff --git a/...src/main/java/it/pagopa/selfcare/onboarding/connector/model/institutions/Institution.java b/...src/main/java/it/pagopa/selfcare/onboarding/connector/model/institutions/Institution.java
@@ -15,6 +15,7 @@ public class Institution {
     private String externalId;
     private String originId;
     private String description;
+    private String parentDescription;
     private String digitalAddress;
     private String address;
     private String zipCode;

diff --git a/...main/java/it/pagopa/selfcare/onboarding/connector/model/onboarding/InstitutionUpdate.java b/...main/java/it/pagopa/selfcare/onboarding/connector/model/onboarding/InstitutionUpdate.java
@@ -12,6 +12,7 @@ public class InstitutionUpdate {
     private String id;
     private InstitutionType institutionType;
     private String description;
+    private String parentDescription;
     private String digitalAddress;
     private String address;
     private String taxCode;

diff --git a/connector/rest/docs/openapi/api-selfcare-onboarding-docs.json b/connector/rest/docs/openapi/api-selfcare-onboarding-docs.json
@@ -1592,6 +1592,9 @@
           "zipCode" : {
             "type" : "string"
           },
+          "parentDescription" : {
+            "type" : "string"
+          },
           "geographicTaxonomies" : {
             "type" : "array",
             "items" : {
@@ -1970,7 +1973,7 @@
         "type" : "string"
       },
       "OnboardingUserRequest" : {
-        "required" : [ "productId", "origin", "originId", "users" ],
+        "required" : [ "productId", "users" ],
         "type" : "object",
         "properties" : {
           "productId" : {
@@ -1984,11 +1987,9 @@
             "type" : "string"
           },
           "origin" : {
-            "minLength" : 1,
             "type" : "string"
           },
           "originId" : {
-            "minLength" : 1,
             "type" : "string"
           },
           "taxCode" : {

diff --git a/...t/resources/stubs/party-process/mappings/getUserInstitutionRelationships_fullyValued.json b/...t/resources/stubs/party-process/mappings/getUserInstitutionRelationships_fullyValued.json
@@ -24,6 +24,7 @@
           "originId": "test",
           "institutionType": "PA",
           "description": "AGENCY X",
+          "parentDescription": "test",
           "digitalAddress": "email@pec.mail.org",
           "address": "via del campo",
           "taxCode": "string",

diff --git a/web/src/main/java/it/pagopa/selfcare/onboarding/web/controller/InstitutionV2Controller.java b/web/src/main/java/it/pagopa/selfcare/onboarding/web/controller/InstitutionV2Controller.java
@@ -9,6 +9,7 @@
 import it.pagopa.selfcare.commons.base.logging.LogUtils;
 import it.pagopa.selfcare.commons.web.model.Problem;
 import it.pagopa.selfcare.onboarding.common.InstitutionType;
+
 import it.pagopa.selfcare.onboarding.core.InstitutionService;
 import it.pagopa.selfcare.onboarding.web.model.CompanyOnboardingDto;
 import it.pagopa.selfcare.onboarding.web.model.InstitutionResource;

diff --git a/web/src/main/java/it/pagopa/selfcare/onboarding/web/model/InstitutionResource.java b/web/src/main/java/it/pagopa/selfcare/onboarding/web/model/InstitutionResource.java
@@ -16,6 +16,9 @@ public class InstitutionResource {
     @ApiModelProperty(value = "${swagger.onboarding.institutions.model.name}")
     private String description;
 
+    @ApiModelProperty(value = "${swagger.onboarding.institutions.model.parentDescription}")
+    private String parentDescription;
+
     @ApiModelProperty(value = "${swagger.onboarding.institutions.model.externalId}")
     private String externalId;
 

diff --git a/web/src/main/resources/swagger/swagger_en.properties b/web/src/main/resources/swagger/swagger_en.properties
@@ -29,6 +29,7 @@ swagger.onboarding.institutions.model.address=Institution's physical address
 swagger.onboarding.institutions.model.digitalAddress=Institution's digitalAddress
 swagger.onboarding.institutions.model.zipCode=Institution's zipCode
 swagger.onboarding.institutions.model.taxCode=Institution's taxCode
+swagger.onboarding.institutions.model.parentDescription=Institution's parent description
 swagger.onboarding.institutions.model.taxCodeInvoicing=Institution's taxCodeInvoicing for electronic invoicing
 swagger.onboarding.institutions.model.subunitCode=Institution's subunitCode
 swagger.onboarding.institutions.model.subunitType=Institution's subunitType