Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-5216] feat: Added parentDescription to InstitutionOnboardings response #330

Merged
merged 7 commits into from
Jul 5, 2024
Merged

[SELC-5216] feat: Added parentDescription to InstitutionOnboardings response #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
219ea0e
[APIM-v2 MIGRATION] change reference to apim-v2 (#320)
manuraf Jul 2, 2024
a5f1322
Merge fix/selc 4371 into release 1.0.9 (#328)
pierpaolodidato89 Jul 2, 2024
6792d46
Update swagger doc
Jul 3, 2024
0aaa6ec
Added parentDescription to institutionOnboardings response
Jul 4, 2024
ed685a2
Merge branch 'main' into feature/SELC-5216
pierpaolodidato89 Jul 4, 2024
8baed89
Updated unit test
Jul 5, 2024
fe30390
Merge branch 'feature/SELC-5216' of https://github.com/pagopa/selfcar…
Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/src/main/resources/swagger/api-docs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3389,6 +3389,10 @@
"type" : "string",
"description" : "Institution's details origin Id"
},
"parentDescription" : {
"type" : "string",
"description" : "Institution's parent description"
},
"taxCode" : {
"type" : "string",
"description" : "Institution's taxCode"
Expand Down
1 change: 1 addition & 0 deletions ...src/main/java/it/pagopa/selfcare/onboarding/connector/model/institutions/Institution.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ public class Institution {
private String externalId;
private String originId;
private String description;
private String parentDescription;
private String digitalAddress;
private String address;
private String zipCode;
Expand Down
1 change: 1 addition & 0 deletions ...main/java/it/pagopa/selfcare/onboarding/connector/model/onboarding/InstitutionUpdate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ public class InstitutionUpdate {
private String id;
private InstitutionType institutionType;
private String description;
private String parentDescription;
private String digitalAddress;
private String address;
private String taxCode;
Expand Down
7 changes: 4 additions & 3 deletions connector/rest/docs/openapi/api-selfcare-onboarding-docs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1592,6 +1592,9 @@
"zipCode" : {
"type" : "string"
},
"parentDescription" : {
"type" : "string"
},
"geographicTaxonomies" : {
"type" : "array",
"items" : {
Expand Down Expand Up @@ -1970,7 +1973,7 @@
"type" : "string"
},
"OnboardingUserRequest" : {
"required" : [ "productId", "origin", "originId", "users" ],
"required" : [ "productId", "users" ],
"type" : "object",
"properties" : {
"productId" : {
Expand All @@ -1984,11 +1987,9 @@
"type" : "string"
},
"origin" : {
"minLength" : 1,
"type" : "string"
},
"originId" : {
"minLength" : 1,
"type" : "string"
},
"taxCode" : {
Expand Down
1 change: 1 addition & 0 deletions ...t/resources/stubs/party-process/mappings/getUserInstitutionRelationships_fullyValued.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"originId": "test",
"institutionType": "PA",
"description": "AGENCY X",
"parentDescription": "test",
"digitalAddress": "email@pec.mail.org",
"address": "via del campo",
"taxCode": "string",
Expand Down
1 change: 1 addition & 0 deletions web/src/main/java/it/pagopa/selfcare/onboarding/web/controller/InstitutionV2Controller.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import it.pagopa.selfcare.commons.base.logging.LogUtils;
import it.pagopa.selfcare.commons.web.model.Problem;
import it.pagopa.selfcare.onboarding.common.InstitutionType;

import it.pagopa.selfcare.onboarding.core.InstitutionService;
import it.pagopa.selfcare.onboarding.web.model.CompanyOnboardingDto;
import it.pagopa.selfcare.onboarding.web.model.InstitutionResource;
Expand Down
3 changes: 3 additions & 0 deletions web/src/main/java/it/pagopa/selfcare/onboarding/web/model/InstitutionResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ public class InstitutionResource {
@ApiModelProperty(value = "${swagger.onboarding.institutions.model.name}")
private String description;

@ApiModelProperty(value = "${swagger.onboarding.institutions.model.parentDescription}")
private String parentDescription;

@ApiModelProperty(value = "${swagger.onboarding.institutions.model.externalId}")
private String externalId;

Expand Down
1 change: 1 addition & 0 deletions web/src/main/resources/swagger/swagger_en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ swagger.onboarding.institutions.model.address=Institution's physical address
swagger.onboarding.institutions.model.digitalAddress=Institution's digitalAddress
swagger.onboarding.institutions.model.zipCode=Institution's zipCode
swagger.onboarding.institutions.model.taxCode=Institution's taxCode
swagger.onboarding.institutions.model.parentDescription=Institution's parent description
swagger.onboarding.institutions.model.taxCodeInvoicing=Institution's taxCodeInvoicing for electronic invoicing
swagger.onboarding.institutions.model.subunitCode=Institution's subunitCode
swagger.onboarding.institutions.model.subunitType=Institution's subunitType
Expand Down
Loading