feat: Immutability policy storage account [#IOPID-752] #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurnedMarshal
changed the title
BurnedMarshal
changed the title
BurnedMarshal
force-pushed
the
IOPID-752-immutability-storage-account
branch
from
4a1dc0f to
cdcac09
Compare
|
@BurnedMarshal I confirm you found a Terraform bug and we are going to open an issue. In the meanwhile, you can use az cli in the Terraform configuration to make the necessary changes |
BurnedMarshal
force-pushed
the
IOPID-752-immutability-storage-account
branch
from
f1c71bd to
5282ae0
Compare
Krusty93
reviewed
Oct 4, 2023
pasqualedevita
previously approved these changes
Oct 4, 2023
Co-authored-by: Andrea Grillo <andrea.grillo@outlook.com>
Krusty93
previously approved these changes
Oct 5, 2023
Krusty93
approved these changes
Oct 5, 2023
diegolagospagopa
approved these changes
Oct 5, 2023
|
🎉 This PR is included in version 7.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Add variables to set the immutability policy params for an Azure Storage.
Optional immutability policy into the module.
Motivation and context
The Blob storage that contains audit logs for legal reason must have an immutability policy to prevent data deletion until the end of the retention policy.
Type of changes
Does this introduce a breaking change?
Other information
The actual version of the
hashicorp/azurermmodule when we change fromUnlockedorDisabledstate of the immutability policy toLockedupdate the terraform state file but doesn't update the resource into the cloud.Run checks
Useful commands to run checks on local machine
bash .utils/terraform_run_all.sh init local pre-commit run -a