fix: [PAYMCLOUD-109] poc GitHub runner on dev ops lab #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit integrates the retrieval of GitHub Personal Access Token (PAT) from Azure Key Vault in the Terraform configuration. It removes the hardcoded PAT from the environment variables and injects it securely from the Key Vault secret. This enhances security by avoiding hardcoding sensitive information in the codebase.
Introduced GitHub PAT in the container environment variables to securely access repositories. Updated `main.tf` to correctly reference the existing Key Vault secret for the GitHub PAT. Removed redundant secret configuration for cleaner code.
Moved GitHub PAT from plain text in locals.tf to secure secret management in main.tf. This change improves security by using the secret_name attribute for handling sensitive credentials.
Updated the Markdown table in the README to use consistent line breaks with `<br/>`. This change ensures better readability and maintainability of the table entries.
Replaced all instances of "/>" with ">" in code blocks for consistency. This change improves readability and maintains a uniform coding style across the documentation.
…on-DevOpsLab' into PAYMCLOUD-109-POC-Github-Runner-on-DevOpsLab
Adjusted spacing to align variables in `variables.tf` and `main.tf` for better readability. Reformatted the README.md input table to ensure consistency and clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Motivation and context
Fix the GITHUB_PAT env management, to make it works a secretRef is needed.
Type of changes
Does this introduce a breaking change?
Other information
Run checks
Useful commands to run checks on local machine
bash .utils/terraform_run_all.sh init local pre-commit run -a