User-defined double output precision #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing a double to an OutputStream current prints at most 6 significant digits (according to the C standard). The function SetDoublePrecision(), added to the Writer classes can be used to fluently set the precision, i.e. the number of significant digits to use for writing the double: Writer<...> writer(...); d.Accept(writer.SetDoublePrecision(12));
As proposed in other patches, it is convenient to pass a user-defined precision for the (programmatic) output of a single double value to an OutputStream. This patch adds an additional overload with an explicit precision argument to the (Pretty)Writer class templates.
|
Merged into local for-upstream/master branch via 2ce917d. |
|
See upstream pull-request Tencent/rapidjson#19. |
|
Merged upstream. |
pah
added a commit
that referenced
this pull request
Aug 11, 2014
This drops #3 and #4, as their functionality has been superseded upstream, see Tencent/rapidjson#97 and Tencent/rapidjson#101. Conflicts: include/rapidjson/prettywriter.h include/rapidjson/reader.h include/rapidjson/writer.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing a
doubleto anOutputStreamcurrent prints at most 6 significantdigits (according to the C standard).
The functions
Set/GetDoublePrecision(), added to theWriterclassescan be used to fluently set the precision, i.e. the number of significant
digits to use for writing the double:
Additionally, a new
Double(double,int)overload is added to theWriterclasses,allowing to programmatically write a single
doublevalue with a custom output precision:An additional unit test
Writer.DoublePrecisionis added as well.See upstream issues