Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e tests CI in github actions #277

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

visch
Copy link

@visch visch commented Apr 21, 2023

Wanted ssh tunnel functionality for MeltanoLabs/tap-postgres#94

Also wanted to test so I used the existing e2e tests, unfortunately a number of broken things in there so this should address most of the. We should probably refactor this as well, but at least they work now!

@coveralls
Copy link

coveralls commented Apr 21, 2023

Coverage Status

Coverage: 91.486% (-0.3%) from 91.766% when pulling 602c50a on visch:patch-1 into d2167a2 on pahaz:master.

@visch visch changed the title Lock Docker version to get CI to pass Fix CI Apr 21, 2023
@visch
Copy link
Author

visch commented Apr 21, 2023

https://github.com/visch/sshtunnel/actions/runs/4765659882/jobs/8471681007?pr=2

This PR fixes the issue with the SSH server not spinng up properly. The leftover issue is in

assert res == (PG_EXPECT, MYSQL_EXPECT, MONGO_EXPECT)

@visch visch changed the title Fix CI Fix e2e CI in github actions Apr 21, 2023
@visch visch changed the title Fix e2e CI in github actions Fix e2e tests CI in github actions Apr 21, 2023
@visch
Copy link
Author

visch commented Apr 21, 2023

@pahaz
Copy link
Owner

pahaz commented May 11, 2023

What about python2 compatibility?

@visch
Copy link
Author

visch commented May 11, 2023

What about python2 compatibility?

I didn't want to mess with it due to actions/runner-images#7401 , do you think it's worth rolling our own here to support 2.*?

I also assumed (wrongly) that setup-python wouldn't support 2.7 but it looks like it still does https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#available-versions-of-python-and-pypy

I can add it in if you'd like!

@visch
Copy link
Author

visch commented May 11, 2023

What about python2 compatibility?

https://github.com/visch/sshtunnel/actions/runs/4949001204 Added Python 2.7 support to the action

@pahaz
Copy link
Owner

pahaz commented May 14, 2023

Your work looks good to me. Could you please resolve the conflicts? It would be better to migrate from CircleCI to GitHub Actions for testing different Python versions.

@pahaz
Copy link
Owner

pahaz commented May 14, 2023

Do you have time to continue your work?

@pahaz pahaz added the wontfix label May 14, 2023
@visch
Copy link
Author

visch commented Jul 15, 2023

Owner

I didn't, I should be able to come back to this at some point :O might be a little bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants