This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
alleviate softmax datatype check #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanyokwok
reviewed
Nov 25, 2022
Comment on lines
+324
to
+328
|
|
||
| // Do not need check dtype args here, since dtype have been infered in op.getType() | ||
| // if (!op.dtype().getType().isa<Torch::NoneType>()) | ||
| // return rewriter.notifyMatchFailure( | ||
| // op, "Unimplemented non-None dtype for softmax"); |
tanyokwok
approved these changes
Nov 25, 2022
tanyokwok
pushed a commit
that referenced
this pull request
Dec 5, 2022
zzpmiracle
added a commit
that referenced
this pull request
Dec 29, 2022
tanyokwok
pushed a commit
that referenced
this pull request
Feb 2, 2023
JamesTheZ
pushed a commit
that referenced
this pull request
Jul 19, 2023
* Fix float width * Fix divide_floor & export promoteTypes api (#9) * To comply with the old pytorch versions * Add native_dropout_backward & native_layer_norm_backward decomposition (#15) * Add native_dropout and related ops pattern (llvm#1211) * [MHLO] fix dot general contract * Fix batch_norm, div.Tensor_mode and folder (#21) * Reimplement linear lowering * Reimplement 2-D rhs for mutmul * Add torchdynamo * Decompose torch.slice_scatter (llvm#1622) * Fix i64 torch.tensor dtype * Add more mhlo basic converters * Alleviate softmax datatype check (#24) * Fix decompose native_batch_norm (#27) * Support group_norm lowering (#25) * Decompose torch.ones/zeros (#28) * Fix softmax output type * Fix gather * Fix some decompose patterns * Not check assert at runtime (#31) * Fix bool tensor attr conversion bug (#32) * Fix mlirDenseElementsAttrBoolGet
JamesTheZ
added a commit
that referenced
this pull request
Jul 19, 2023
* Fix float width * Fix divide_floor & export promoteTypes api (#9) * To comply with the old pytorch versions * Add native_dropout_backward & native_layer_norm_backward decomposition (#15) * Add native_dropout and related ops pattern (llvm#1211) * [MHLO] fix dot general contract * Fix batch_norm, div.Tensor_mode and folder (#21) * Reimplement linear lowering * Reimplement 2-D rhs for mutmul * Add torchdynamo * Decompose torch.slice_scatter (llvm#1622) * Fix i64 torch.tensor dtype * Add more mhlo basic converters * Alleviate softmax datatype check (#24) * Fix decompose native_batch_norm (#27) * Support group_norm lowering (#25) * Decompose torch.ones/zeros (#28) * Fix softmax output type * Fix gather * Fix some decompose patterns * Not check assert at runtime (#31) * Fix bool tensor attr conversion bug (#32) * Fix mlirDenseElementsAttrBoolGet Co-Authored-By: ZHENG, Zhen <zzchman@gmail.com>
JamesTheZ
added a commit
that referenced
this pull request
Jul 25, 2023
* Rewrite mhlo with stablehlo after rebase. * Fix BAZEL building error of multiple definition. * Fix float width * Fix divide_floor & export promoteTypes api (#9) * To comply with the old pytorch versions * Add native_dropout_backward & native_layer_norm_backward decomposition (#15) * Add native_dropout and related ops pattern (llvm#1211) * [MHLO] fix dot general contract * Fix batch_norm, div.Tensor_mode and folder (#21) * Reimplement linear lowering * Reimplement 2-D rhs for mutmul * Add torchdynamo * Decompose torch.slice_scatter (llvm#1622) * Fix i64 torch.tensor dtype * Add more mhlo basic converters * Alleviate softmax datatype check (#24) * Fix decompose native_batch_norm (#27) * Support group_norm lowering (#25) * Decompose torch.ones/zeros (#28) * Fix softmax output type * Fix gather * Fix some decompose patterns * Not check assert at runtime (#31) * Fix bool tensor attr conversion bug (#32) * Fix mlirDenseElementsAttrBoolGet --------- Co-authored-by: ZHENG, Zhen <zzchman@gmail.com>
JamesTheZ
added a commit
that referenced
this pull request
Jul 25, 2023
* Rewrite mhlo with stablehlo after rebase. * Fix BAZEL building error of multiple definition. * Fix float width * Fix divide_floor & export promoteTypes api (#9) * To comply with the old pytorch versions * Add native_dropout_backward & native_layer_norm_backward decomposition (#15) * Add native_dropout and related ops pattern (llvm#1211) * [MHLO] fix dot general contract * Fix batch_norm, div.Tensor_mode and folder (#21) * Reimplement linear lowering * Reimplement 2-D rhs for mutmul * Add torchdynamo * Decompose torch.slice_scatter (llvm#1622) * Fix i64 torch.tensor dtype * Add more mhlo basic converters * Alleviate softmax datatype check (#24) * Fix decompose native_batch_norm (#27) * Support group_norm lowering (#25) * Decompose torch.ones/zeros (#28) * Fix softmax output type * Fix gather * Fix some decompose patterns * Not check assert at runtime (#31) * Fix bool tensor attr conversion bug (#32) * Fix mlirDenseElementsAttrBoolGet
JamesTheZ
added a commit
that referenced
this pull request
Jul 27, 2023
* Rewrite mhlo with stablehlo after rebase. * Fix BAZEL building error of multiple definition. * Fix float width * Fix divide_floor & export promoteTypes api (#9) * To comply with the old pytorch versions * Add native_dropout_backward & native_layer_norm_backward decomposition (#15) * Add native_dropout and related ops pattern (llvm#1211) * [MHLO] fix dot general contract * Fix batch_norm, div.Tensor_mode and folder (#21) * Reimplement linear lowering * Reimplement 2-D rhs for mutmul * Add torchdynamo * Decompose torch.slice_scatter (llvm#1622) * Fix i64 torch.tensor dtype * Add more mhlo basic converters * Alleviate softmax datatype check (#24) * Fix decompose native_batch_norm (#27) * Support group_norm lowering (#25) * Decompose torch.ones/zeros (#28) * Fix softmax output type * Fix gather * Fix some decompose patterns * Not check assert at runtime (#31) * Fix bool tensor attr conversion bug (#32) * Fix mlirDenseElementsAttrBoolGet
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.