Completed #27
Open
Completed #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| string_store = string.gsub(/[_-]/,' ').split(/\s/) | ||
| if string_store.include? word | ||
| return :yes.to_sym |
There was a problem hiding this comment.
you're calling #to_sym on something that is already a symbol!
|
I like the overall approach - split the string into an array of words, then check whether that array contains the word in question. |
| return :yes.to_sym | ||
| else | ||
| return :no.to_sym | ||
| end | ||
| end |
There was a problem hiding this comment.
Since that if statement is the last thing to be evaluated in the method, the return statements aren't needed. In general, Ruby style is to skip the use of return except for early returns (e.g. guard clauses).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jaybobo @sjreich @mikegee @sampriddy