Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text scaling caused a memory leak in every label 🫠 #252

Closed
pakerwreah opened this issue Sep 23, 2024 · 0 comments
Closed

Text scaling caused a memory leak in every label 🫠 #252

pakerwreah opened this issue Sep 23, 2024 · 0 comments
Assignees
@pakerwreah
Labels
bug Something isn't working
Milestone
v1.13.3

Comments

@pakerwreah
Copy link
Owner

Calling super inside an escaping closure is not a good idea.
It will necessarily create a retain cycle, because capturing super weakly is not supported.

Xcode is a bitch and won't warn you either.

Because of that, we have to create an auxiliary method to set fonts on the base class.
@pakerwreah pakerwreah added the bug Something isn't working label Sep 23, 2024
@pakerwreah pakerwreah added this to the v1.13.3 milestone Sep 23, 2024
@pakerwreah pakerwreah self-assigned this Sep 23, 2024
pakerwreah added a commit that referenced this issue Sep 23, 2024
@pakerwreah
Fix text scaling memory leak 💧 (#252)
dfaf8e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pakerwreah pakerwreah

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.13.3
Development

No branches or pull requests
1 participant
@pakerwreah