Update go version as well as toolchain version. #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this is because many of our dependencies have higher versions of go than we do and we would rather keep up to date with them vs supporting older versions of go. Especially because most of our products are binaries and not libraries.
ForestEckhardt
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the action that updates the go toolchain version to also update the
goversion in addition to updating thetoolchainversion. This is necessary because some of our dependencies have higher versions of go than we do and in order to keep them up to date we must also bump to the minimum version of go that they have. Rather than trying to identify the lowest-common-denominator across all dependencies it is easier to always use the latest version.If we wanted to ensure that we did not need the latest version of go, we could choose to not bump these dependencies. But I think we should keep our dependencies up to date and accept the golang bump. Especially because most of our products are binaries and not libraries, and hence we can control the version of golang they are built with.
See this conversation for more details.
I opted to keep the
toolchaindirective even though it's probably no longer necessary because I felt like being explicit is probably better than relying on the default behavior, given how confusing this situation is for all of us.