-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable support for node & yarn detection #216
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable support for node & yarn detection
pivotal-david-osullivan
added
semver:minor
A change requiring a minor version bump
type:enhancement
A general enhancement
labels
Feb 15, 2023
dmikusa
requested changes
Feb 15, 2023
Co-authored-by: Daniel Mikusa <dan@mikusa.com>
Co-authored-by: Daniel Mikusa <dan@mikusa.com>
Co-authored-by: Daniel Mikusa <dan@mikusa.com>
5 tasks
Bump 🙂 |
5 tasks
dmikusa
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable support for node & yarn detection
Alternative to #215
Summary
This PR adds support for detection of a
package.json
oryarn.lock
, which will cause the following buildpacks/dependencies to be required as part of the build:yarn.lock
- requires install ofyarn
andnode
dependencies (can be provided by theyarn
&node-engine
buildpacks)package.json
- requires install ofnode
dependency (can be provided by thenode-engine
buildpack)To enable support for detection of these files, users should set the environment variable
BP_JAVA_INSTALL_NODE
totrue
(defaults tofalse
to prevent false-positive node builds).The buildpack will check the application root for the
package.json
oryarn.lock
file. Users can set variables supported by the NodeEngine buildpack, such asBP_NODE_PROJECT_PATH
, which can contain a sub-directory within the app root to search for these files.Full implementation will require both the Yarn and NodeEngine buildpacks to be added to the Java composite order group as optional.
Use Cases
Enables projects which build frontend/javascript code to run commands such as 'yarn' to build alongside Java code. See paketo-buildpacks/java#651.
Checklist