Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CGO #130

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Disable CGO #130

merged 1 commit into from
Sep 22, 2022

Conversation

ryanmoran
Copy link
Member

Summary

We should be disabling CGO for the jam binary so that we don't run into dynamic linking issues like this: https://github.com/paketo-buildpacks/bundler/actions/runs/3107193464/jobs/5035101374#step:13:8

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@ryanmoran ryanmoran requested a review from a team as a code owner September 22, 2022 18:26
@sophiewigmore sophiewigmore merged commit 7f125e5 into main Sep 22, 2022
@sophiewigmore sophiewigmore deleted the disable-cgo branch September 22, 2022 19:36
@fg-j
Copy link

fg-j commented Sep 22, 2022

Did this also come up in some other repo/situation? I seem to remember seeing a notification float by...

@sophiewigmore
Copy link
Member

@sophiewigmore
Copy link
Member

We were seeing failures in our integration tests too at some point a few weeks ago

@ryanmoran
Copy link
Member Author

This was uncovered by a couple of things, the commits that bumped our GHA target OS to Jammy as well as a recent bump of the Syft package that imported a package with CGO bindings. We then started building binaries that didn't explicitly disable CGO in Jammy and then trying to run them on Bionic or Alpine. This has shown up as a number of error messages referencing missing C APIs.

@fg-j fg-j added the semver:patch A change requiring a patch version bump label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants