update-buildpack now migrates to CNB registry #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- By default the upgrade-buildpack command will now try and update all URIs in package.toml to use CNB registry URIs. Use the --no-cnb-registry flag to revert to the old style of updating which will just try and find the most up to date image ref.
ryanmoran
reviewed
Mar 18, 2022
internal/image_test.go
Outdated
| "_link": "https://registry.buildpacks.io//api/v1/buildpacks/some-ns/some-name/0.1.0" | ||
| } | ||
| ] | ||
| }`) |
There was a problem hiding this comment.
FYI, JSON is whitespace agnostic. This means you can indent this code so that it lines up a bit nicer with the test cases.
There was a problem hiding this comment.
I am more than happy to give it a quick run through to indent.
There was a problem hiding this comment.
Should be all lined up now
ryanmoran
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URIs in package.toml to use CNB registry URIs. Use the --no-cnb-registry
flag to revert to the old style of updating which will just try and find
the most up to date image ref.
Checklist