Jjbustamante feature/support multiple artifacts of different types #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
- Adds single new ArtifactResolver method, ResolveMany & tests - Uses ResolveMany in Application to check for artifacts - If a single artifact is returned, check if its a file then proceed using the existing procedure. If it's a directory, then copy directory contents to the layer. - If multiple artifacts are returned, check and persist all files and all directory contents Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
- Adds more test cases around matching scenarios that were not previously covered - Adds more test cases around file copies that were not previously covered - Changes the behavior of how a directory is persisted to the layer. Previously, the directory contents would be copied to the root of the layer. This leaves a potential problem if directory A and directory B both have a file with the same name. In that case, the file from whatever directory is copied second would overwrite the file from the first directory. This changes the behavior such that files copied out of directory A are store under the layer in a directory named A and files out of a directory B are stored under the layer in a directory B. This is a slight change though as the files restored back out of the layer will now be in sub directories. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
dmikusa
added
type:enhancement
…cts-of-different-types
dmikusa
deleted the
jjbustamante-feature/support-multiple-artifacts-of-different-types
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adjustments to paketo-buildpacks/native-image#124.
Checklist