Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip generation of label-base BOM #112

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Skip generation of label-base BOM #112

merged 2 commits into from
Mar 2, 2022

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Feb 25, 2022

Summary

When $BP_BOM_LABEL_DISABLED=true, libpak will throw away label-based BOM information. This PR also looks at that env variable and will skip what is an expensive operation, i.e. fetching all the metadata from the build tool. By default, the label-based BOM is generated so this does not impact that scenario. If specifically disabled, then this will make the build faster.

Use Cases

If you don't want the label-based BOM, then you shouldn't have to wait for it to generate. This PR makes builds faster. It can also work around some bugs. For example, if you map in your Maven directory from your local machine this can cause failures or make things really slow.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

When `$BP_BOM_LABEL_DISABLED=true`, libpak will throw away label-based BOM information. This PR also looks at that env variable and will skip what is an expensive operation, i.e. fetching all the metadata from the build tool. By default, the label-based BOM is generated so this does not impact that scenario. If specifically disabled, then this will make the build faster.

Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Feb 25, 2022
@dmikusa dmikusa requested a review from a team February 25, 2022 20:57
@dmikusa dmikusa merged commit 9feeeef into main Mar 2, 2022
@dmikusa dmikusa deleted the skip-bom-faster branch March 2, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants