Support source-removal logic in libbs #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
dmikusa
added
type:enhancement
dmikusa
approved these changes
Sep 4, 2022
|
Looks good to me. This is a fairly core change though, so I'm going to let @pivotal-david-osullivan take a look as well. If you think it's good @pivotal-david-osullivan feel free to merge. |
Co-authored-by: David O'Sullivan <31728678+pivotal-david-osullivan@users.noreply.github.com>
Co-authored-by: David O'Sullivan <31728678+pivotal-david-osullivan@users.noreply.github.com>
|
@pivotal-david-osullivan should be good to go :) |
pivotal-david-osullivan
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sambhav Kothari skothari44@bloomberg.net
Summary
Adds support for source-removal logic in libbs. Instead of completely empty-ing out the application directory, only relevant files are removed BEFORE copying back the interesting files to the application directory.
Fixes #103
Use Cases
Checklist