Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close #434 : Better UX when there's not the desired JRE #436

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Close #434 : Better UX when there's not the desired JRE #436

merged 2 commits into from
Nov 12, 2024

Conversation

anthonydahanne
Copy link
Member

  • Provide better error messages in case the user has requested, via BP_JVM_VERSION or sdkmanrc a Java version that is not available in the buildpack
  • Try and find a more recent JRE/JDK version in case the Manifest found version is not available (best guess)
  • In case there's not even a JDK matching the non-available desired JRE version, return the error instead of moving on with non-existing JDK

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@anthonydahanne anthonydahanne requested a review from a team as a code owner November 8, 2024 15:29
@anthonydahanne anthonydahanne added type:enhancement A general enhancement semver:minor A change requiring a minor version bump labels Nov 8, 2024
@anthonydahanne
Close #434
0e9aca2 
* Provide better error messages in case the user has requested, via BP_JVM_VERSION or sdkmanrc a Java version that is not available in the buildpack
* Try and find a more recent JRE/JDK version in case the Manifest found version is not available (best guess)
* In case there's not even a JDK matching the non-available desired JRE version, return the error instead of moving on with non-existing JDK
@anthonydahanne
Close #434
e6513ec 
* Try and find a more recent JRE/JDK version in case the Manifest found version is not available (best guess - trying only the next major version)
@anthonydahanne anthonydahanne merged commit d0895b1 into main Nov 12, 2024
4 checks passed
@anthonydahanne anthonydahanne deleted the fix-434 branch November 12, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmikusa dmikusa dmikusa approved these changes

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonydahanne @dmikusa