GH Issue 70 - mvnw file from Windows not executable #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added function to convert CRLF formatting to LF in the mvnw file Added function to convert CRLF formatting to LF in the mvnw file Added function to convert CRLF formatting to LF in the mvnw file
dmikusa
added
semver:patch
dmikusa
requested changes
Jul 23, 2021
* Moved mvnw file processing/cleaning to a separate function * Changed util function used from bytes.Replace to bytes.ReplaceAll for simplicity * Removed check on whether CRLF is present in file * Changed test to call the new function only [Resolves paketo-buildpacks#70]
pivotal-david-osullivan
force-pushed
the
gh_issue_70
branch
from
47e9867
to
f8353e5
Compare
dmikusa
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #70
Use Cases
An mvnw file with Windows line endings (CRLF) will cause the build in a linux container to fail due to the unrecognised formatting. The error appears as a file not found:
fork/exec /workspace/source/app/mvnw: no such file or directoryThis PR adds a function which converts CRLF endings to LF so that the mvnw file can be executed successfully.
Checklist