Restructure rfc

[arjun024]

Readable

[dmikusa]

I feel like we can drop this env variable. If we properly install PHP, the cli should be on the path. You'll also get php-config which is an exec you can use to locate things like the INI file, extensions dir, etc.. so I don't think there's a reason for the buildpacks to create a non-standard way of finding similar info.

[arjun024]

So the ini file will be dropped on to the php layer by the dependency. How would the php-config binary or the php-installation know where this file is? Wouldn't it be in a custom named directory in the layer directory?

[dmikusa]

Basically, the buildpacks will assume that PHP is installed and available on the path (which php-dist-cnb does). Part of what's installed is php-config, which you can use to query information like this. You can shell out and run php-config and ask about the locations of these files.

The only env variables we should set are the standard ones that tell PHP where to find the INI files.

[dmikusa]

We basically just need to delete this line item. The php-dist cnb doesn't need to do this because other cnb's can use php-config to locate the php.ini file.

[arjun024]

@dmikusa-pivotal In the current design, downstream buildpacks do not require php at build. For them to use php-config, php has to be required at build. I can make them require php at build as well so they can call php-config and other binaries that come with php. Does that sound good?

[dmikusa]

Hmm. I'm tempted to say yes, let's make it available at build so other cnb's can use php-config. Do you see any downside to that? Is there a performance penalty for making it required at build by more cnbs?

[arjun024]

I don't believe there's a penalty. Updated

[dmikusa]

👍