Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close #996: Bump to Go 1.18 #1011

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Close #996: Bump to Go 1.18 #1011

merged 3 commits into from
Feb 14, 2023

Conversation

anthonydahanne
Copy link
Member

@anthonydahanne anthonydahanne commented Feb 13, 2023 •
edited
Loading

Summary

  • to allow actions requiring Go 1.18 to continue building

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@anthonydahanne anthonydahanne requested a review from a team as a code owner February 13, 2023 14:26
@dmikusa
Copy link
Contributor

dmikusa commented Feb 13, 2023

Looks good to me. One thing that would be helpful. Can you add a small section to the README with instructions for updating Go to the next version, i think there's two spots that need changed. This Dockerfile and also in Octo. Just so we don't forget in the future. Thanks!

@anthonydahanne
Close paketo-buildpacks#996: Bump to Go 1.18
7c0f80d 
* to allow actions requiring Go 1.18 to continue building
* update the documentation to indicate where to upgrade
@anthonydahanne
Copy link
Member Author

Please let me know @dmikusa if the documentation update is clear enough! thanks!

@dmikusa dmikusa added type:dependency-upgrade A dependency upgrade semver:patch A change requiring a patch version bump labels Feb 14, 2023
dmikusa
dmikusa requested changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@dmikusa dmikusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added a little more detail. If that looks good, we can merge this one. Thanks!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
anthonydahanne and others added 2 commits February 14, 2023 09:06
@anthonydahanne @dmikusa
Update README.md
df1d49b 
rephrase when to update

Co-authored-by: Daniel Mikusa <dan@mikusa.com>
@anthonydahanne @dmikusa
Update README.md
3a92bf9 
* add info about octo version update

Co-authored-by: Daniel Mikusa <dan@mikusa.com>
dmikusa
dmikusa approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@dmikusa dmikusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dmikusa dmikusa merged commit 5f4177c into paketo-buildpacks:main Feb 14, 2023
@anthonydahanne anthonydahanne deleted the fix-996-go-1.18 branch February 14, 2023 16:20
This was referenced Mar 22, 2023
Merged
Merged
Merged
Merged
Merged
@buildpack-bot buildpack-bot mentioned this pull request Mar 22, 2023
Merged
@paketo-bot paketo-bot mentioned this pull request Mar 22, 2023
Merged
@buildpack-bot buildpack-bot mentioned this pull request Mar 22, 2023
Merged
This was referenced Mar 22, 2023
Merged
Merged
Merged
Merged
@buildpack-bot buildpack-bot mentioned this pull request Mar 22, 2023
Merged
This was referenced Mar 22, 2023
Merged
Merged
Merged
Merged
This was referenced Mar 22, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@paketo-bot paketo-bot mentioned this pull request Apr 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmikusa dmikusa dmikusa approved these changes

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump type:dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonydahanne @dmikusa