Change go get -u to fetch minor/patch updates
#1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmikusa
added
type:bug
Previously we were using `get get -u all`, which was great but started pulling in major version updates which of course break things. This PR switches to not pull in major version bumps, which is the default behavior of `go get -u` and it adds the `-t` flag so we also update test modules. I think this is a safer approach, and it allows us to manually update major version bumps which will usually require manual intervention anyway. Signed-off-by: Daniel Mikusa <dan@mikusa.com>
pivotal-david-osullivan
approved these changes
Jun 29, 2023
This was referenced Jun 29, 2023
This was referenced Jun 29, 2023
This was referenced Jun 30, 2023
This was referenced Jul 17, 2023
This was referenced Jul 19, 2023
This was referenced Sep 25, 2023
This was referenced Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously we were using
get get -u all, which was great but started pulling in major version updates which of course break things. This PR switches to not pull in major version bumps, which is the default behavior ofgo get -uand it adds the-tflag so we also update test modules. I think this is a safer approach, and it allows us to manually update major version bumps which will usually require manual intervention anyway.