Strip patch version off Go version #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input version is two digits (major.minor), but for some buildpacks the version in the go.mod file has three digits. This didn't actually change the go.mod file, but it caused a mismatch if old/new versions, which caused the wrong title to be filed on PRs. Stripping off the patch version of the go version read out of the go.mod file should enable it to match unless the major.minor is different. Signed-off-by: Daniel Mikusa <dan@mikusa.com>
dmikusa
added
type:bug
anthonydahanne
approved these changes
Aug 19, 2024
This was referenced Aug 21, 2024
This was referenced Aug 22, 2024
This was referenced Aug 22, 2024
This was referenced Aug 22, 2024
This was referenced Aug 22, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The input version is two digits (major.minor), but for some buildpacks the version in the go.mod file has three digits. This didn't actually change the go.mod file, but it caused a mismatch if old/new versions, which caused the wrong title to be filed on PRs.
Stripping off the patch version of the go version read out of the go.mod file should enable it to match unless the major.minor is different.