Removed the Docker Login step from Create Test Package job as it fail… #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for dependabot and is unnecessary for the test
pivotal-david-osullivan
added
semver:patch
This was referenced Aug 27, 2021
This was referenced Aug 30, 2021
This was referenced Aug 30, 2021
This was referenced Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s for dependabot and is unnecessary for the test
Summary
Dependabot-created PRs always fail the 'Create Package Tests' action, as the 'Docker Login' step is not provided with any credentials (expected). This step should not be run anyway but does due to a conditional logic bug. Opted to remove the 'Docker Login' step entirely from this action because it does not need to connect to Docker anyway.
Use Cases
Checklist