Add conditional logic for pulling out the Java version number #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Alibaba Dragonwell 8 has version numbers that don't match the Java version, so we have to dig into the Java download and pull the Java version out of the `release` file. - Alibaba Dragonwell 11+ have version numbers that match the Java versions, so we don't need to download the file. We can just extract the version from the asset name. This also fixes an issue with Java 17.0.0 where the `release` file has `17` not `17.0.0` which was breaking this action. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
dmikusa
added
type:bug
This was referenced Oct 26, 2021
This was referenced Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
releasefile.releasefile has17not17.0.0which was breaking this action.Use Cases
Checklist